[PM-33569] feat: Handle displaying login request for alert style notification#2482
Merged
matt-livefront merged 3 commits intomainfrom Mar 26, 2026
Merged
Conversation
github-actions
bot
added
the
app:password-manager
|
Claude finished @matt-livefront's task in 2m 17s —— View job Code Review: PM-33569 Handle displaying login request for alert style notification
SummaryThis PR cleanly handles the transition from silent push notifications (with local banners) to alert-style push notifications for login-with-device requests. The implementation is well-structured and covers all the necessary paths. No actionable findings identified. The code looks good:
TODOs are properly tagged with the follow-up ticket (PM-33817) for removing the legacy local notification approach. 👍 |
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2482 +/- ##
========================================
Coverage 86.88% 86.89%
========================================
Files 1844 1844
Lines 163171 163313 +142
========================================
+ Hits 141769 141908 +139
- Misses 21402 21405 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fedemkr
approved these changes
Mar 25, 2026
matt-livefront
deleted the
matt/PM-33569-auth-request-notification-handling
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-33569
📔 Objective
This adds support for receiving alert-style push notifications for login with device.
In the current approach, the backend sends a silent push notification. The app receives this notification in the background and schedules a local notification for the user to see.
When switching to alert-style push notifications, the notification extension (#2444) will first receive the notification and update the contents of the notification. This alert will display automatically. But there's two changes that are needed to support this flow: